alro65
13a2867ef6
End-to-end implementation per docs/sprint-2.5-plan.md. New requirement added by user mid-sprint: 4-role RBAC (Super Admin / Engineer / Owner / User) with dual-auth for Engineer flashing firmware, plus a "mini Arduino IDE" inside the Studio. Tests: pytest 231/231 green (129 Sprint 2 + 102 Sprint 2.5 new). RBAC core (arautopilot/core/): - rbac.py: 4 roles, 12 capabilities, immutable capability matrix, has() / capabilities_of() / require() / requires_dual_auth() helpers. Engineer flashing firmware needs SA approval; everything else is single-factor. - user.py: User model with PBKDF2-HMAC-SHA256 PIN hashing (200k iters, 16-byte salt, self-describing hash format for future migrations). 4-8 digit numeric PINs enforced. - user_store.py: JSON-backed user database. seed_demo_users() for first-run UX. - audit.py: append-only JSONL audit log. AuditEvent with timestamp, user_id, role, action, target, outcome, reason, secondary_user_id for dual-auth, optional extra payload. Crypto signing of lines deferred to Sprint 8. Studio GUI (arautopilot/studio/): - app.py: real entry point (replaces Sprint 0 stub). --seed-demo populates demo users without launching GUI; --data-dir overrides the ~/.ar-autopilot/studio/ default. - session.py: Session + SessionHolder. check() always audits the decision; verify_super_admin_pin() + log_dual_auth_grant() for dual-auth flows. - login_window.py: modal login dialog with user picker + PIN field. Audits login attempts (success and bad-PIN denials). - main_window.py: top-level window with sidebar (user + role + caps) and tab area (Overview, Flash Console, Project placeholder, Telemetry placeholder). - flash_console.py: the "mini Arduino IDE". Lists serial ports via pyserial; picks firmware variant (esp32-dev / esp32-debug); compiles via 'pio run'; flashes via 'pio run -t upload --upload-port <port>'; streams pio output to a dark-themed read-only console; supports cancel. For Engineer flashes, asks the Super Admin for their PIN inline before invoking pio. Records dual-auth grant + pio exit code in the audit log. Dependencies: - New [project.optional-dependencies] group 'studio': PySide6>=6.6, pyserial>=3.5, platformio>=6.1. Kept optional so the core can be installed in lean / CI environments. Tests (arautopilot/tests/): - test_rbac.py: 32 tests for capability matrix, dual-auth policy, no-privilege-escalation invariants, partial overlap between roles. - test_user.py: 11 tests for PIN hashing, verification, salting, serialisation, field validators. - test_audit.py: 9 tests for JSONL append, immutability, round-trip, corrupt-line detection, dual-auth event shape, blank-line tolerance. - test_user_store.py: 10 tests for CRUD, persistence, role filtering, demo seed idempotency. - test_session.py: 9 tests for capability checks + audit side effects, SA PIN verification, dual-auth recording, SessionHolder lifecycle. - test_studio_smoke.py: 5 headless tests verifying Studio modules import without a display server, --seed-demo works, helpers safe to call without hardware. NOT in Sprint 2.5 (intentional): - Crypto signing of audit log lines (hash-chain) -- Sprint 8 - HWID binding of the user store -- Sprint 8 - Project configurator + .appack compiler -- Sprint 4 - Flutter bridge display -- Sprint 4 - Telemetry dashboard tab -- Sprint 4 - Serial monitor as a separate tab -- future enhancement Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
103 lines
3.2 KiB
Python
103 lines
3.2 KiB
Python
"""Tests for ``arautopilot.core.user_store``."""
|
|
|
|
from __future__ import annotations
|
|
|
|
from pathlib import Path
|
|
|
|
import pytest
|
|
|
|
from arautopilot.core.rbac import Role
|
|
from arautopilot.core.user import User
|
|
from arautopilot.core.user_store import UserStore, seed_demo_users
|
|
|
|
|
|
def test_empty_store_starts_empty(tmp_path: Path) -> None:
|
|
s = UserStore(tmp_path / "users.json")
|
|
assert len(s) == 0
|
|
assert s.all_users() == []
|
|
|
|
|
|
def test_add_and_get(tmp_path: Path) -> None:
|
|
s = UserStore(tmp_path / "users.json")
|
|
u = User.create(display_name="A", role=Role.USER, pin="1234")
|
|
s.add(u)
|
|
assert len(s) == 1
|
|
assert s.get(u.user_id) is not None
|
|
assert s.get(u.user_id).display_name == "A"
|
|
|
|
|
|
def test_duplicate_user_id_rejected(tmp_path: Path) -> None:
|
|
s = UserStore(tmp_path / "users.json")
|
|
u = User.create(display_name="A", role=Role.USER, pin="1234")
|
|
s.add(u)
|
|
with pytest.raises(ValueError):
|
|
s.add(u)
|
|
|
|
|
|
def test_remove_unknown_raises(tmp_path: Path) -> None:
|
|
s = UserStore(tmp_path / "users.json")
|
|
with pytest.raises(KeyError):
|
|
s.remove("nonexistent")
|
|
|
|
|
|
def test_persistence_across_instances(tmp_path: Path) -> None:
|
|
p = tmp_path / "users.json"
|
|
s = UserStore(p)
|
|
s.add(User.create(display_name="A", role=Role.USER, pin="1234"))
|
|
s.add(User.create(display_name="B", role=Role.OWNER, pin="5678"))
|
|
|
|
s2 = UserStore(p)
|
|
assert len(s2) == 2
|
|
a = s2.find_by_name("A")
|
|
b = s2.find_by_name("B")
|
|
assert a is not None and a.verify_pin("1234")
|
|
assert b is not None and b.verify_pin("5678")
|
|
|
|
|
|
def test_by_role_filters_correctly(tmp_path: Path) -> None:
|
|
s = UserStore(tmp_path / "users.json")
|
|
s.add(User.create(display_name="SA", role=Role.SUPER_ADMIN, pin="0001"))
|
|
s.add(User.create(display_name="Eng1", role=Role.ENGINEER, pin="0002"))
|
|
s.add(User.create(display_name="Eng2", role=Role.ENGINEER, pin="0003"))
|
|
s.add(User.create(display_name="Own", role=Role.OWNER, pin="0004"))
|
|
assert len(s.by_role(Role.ENGINEER)) == 2
|
|
assert len(s.by_role(Role.OWNER)) == 1
|
|
assert len(s.by_role(Role.USER)) == 0
|
|
|
|
|
|
def test_seed_demo_creates_one_of_each_role(tmp_path: Path) -> None:
|
|
s = UserStore(tmp_path / "users.json")
|
|
seed_demo_users(s)
|
|
assert len(s) == 4
|
|
assert s.find_by_name("Alvaro") is not None
|
|
assert s.find_by_name("Alvaro").role is Role.SUPER_ADMIN
|
|
assert s.find_by_name("Alvaro").verify_pin("1111")
|
|
|
|
|
|
def test_seed_demo_idempotent(tmp_path: Path) -> None:
|
|
s = UserStore(tmp_path / "users.json")
|
|
seed_demo_users(s)
|
|
seed_demo_users(s) # no-op
|
|
assert len(s) == 4
|
|
|
|
|
|
def test_replace_updates_existing(tmp_path: Path) -> None:
|
|
s = UserStore(tmp_path / "users.json")
|
|
u = User.create(display_name="A", role=Role.USER, pin="1234")
|
|
s.add(u)
|
|
u2 = u.set_pin("9999")
|
|
s.replace(u2)
|
|
assert len(s) == 1
|
|
fetched = s.get(u.user_id)
|
|
assert fetched is not None
|
|
assert fetched.verify_pin("9999")
|
|
assert not fetched.verify_pin("1234")
|
|
|
|
|
|
def test_membership_test(tmp_path: Path) -> None:
|
|
s = UserStore(tmp_path / "users.json")
|
|
u = User.create(display_name="A", role=Role.USER, pin="1234")
|
|
s.add(u)
|
|
assert u.user_id in s
|
|
assert "nope" not in s
|